Merged
Conversation
… for looping each of them
Contributor
Author
|
Oh.. the pre-commit failed somehow. |
Contributor
Author
|
I also updated pre-commit hooks to use |
Holger-Bartel
approved these changes
Dec 6, 2025
Contributor
Holger-Bartel
left a comment
Holger-Bartel
left a comment
There was a problem hiding this comment.
Wow, this is really a deep-dive improvement. I got the idea. I approve, provided you ran an exhaustive test that the resulting data are exactly the same!
Contributor
|
@bbkchdhry please review too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization in the compute function by replacing old loop method with np vstack and computing it directly.